Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1145563002: Revert of Add the chrome.fileSystem.onVolumeListChanged event. (Closed)

Created:
5 years, 7 months ago by henrika (OOO until Aug 14)
Modified:
5 years, 7 months ago
Reviewers:
mtomasz, benwells
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add the chrome.fileSystem.onVolumeListChanged event. (patchset #2 id:20001 of https://codereview.chromium.org/1135383002/) Reason for revert: Seems to break browser_tests failed interactive_ui_tests on Linux Chromium OS ASan LSan Tests (1). This CL was the best I could find in the blame list. Reverting as Chrome sheriff to see if it helps. See https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1252 Original issue's description: > Add the chrome.fileSystem.onVolumeListChanged event. > > This CL adds an event which notifies extension about changed list of volumes > which can be requested via chrome.fileSystem.requestFileSystem. > > TEST=browser_tests: *OnVolumeListChanged* > BUG=440674 > > Committed: https://crrev.com/a1cc3a6222b0027a3fcf7cf31787950b0496b85f > Cr-Commit-Position: refs/heads/master@{#330047} TBR=benwells@chromium.org,mtomasz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=440674 Committed: https://crrev.com/1edc0b3fad5ec31765b6a2435db84713ba46cdb6 Cr-Commit-Position: refs/heads/master@{#330064}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -181 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_api.cc View 6 chunks +15 lines, -50 lines 0 comments Download
M chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc View 7 chunks +1 line, -67 lines 0 comments Download
M chrome/common/extensions/api/file_system.idl View 2 chunks +0 lines, -8 lines 0 comments Download
D chrome/test/data/extensions/api_test/file_system/on_volume_list_changed/background.js View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/test/data/extensions/api_test/file_system/on_volume_list_changed/manifest.json View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
henrika (OOO until Aug 14)
Created Revert of Add the chrome.fileSystem.onVolumeListChanged event.
5 years, 7 months ago (2015-05-15 08:35:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145563002/1
5 years, 7 months ago (2015-05-15 08:35:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 08:36:21 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 08:37:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1edc0b3fad5ec31765b6a2435db84713ba46cdb6
Cr-Commit-Position: refs/heads/master@{#330064}

Powered by Google App Engine
This is Rietveld 408576698