Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: media/midi/midi_manager_alsa.h

Issue 1145533004: Eliminate some trivial accessors and use "= default" for some required destructors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/midi/midi_manager_alsa.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/midi/midi_manager_alsa.h
diff --git a/media/midi/midi_manager_alsa.h b/media/midi/midi_manager_alsa.h
index e8b2f6b631f8fc9555bf33b10fc2094761772462..6228e574db3df3021706b9cdcd535f921e13f355 100644
--- a/media/midi/midi_manager_alsa.h
+++ b/media/midi/midi_manager_alsa.h
@@ -164,7 +164,7 @@ class MIDI_EXPORT MidiManagerAlsa final : public MidiManager {
protected:
MidiPortStateBase();
- ScopedVector<MidiPort>* ports();
+ ScopedVector<MidiPort>* ports() { return &ports_; }
private:
ScopedVector<MidiPort> ports_;
@@ -224,10 +224,10 @@ class MIDI_EXPORT MidiManagerAlsa final : public MidiManager {
Port(const std::string& name, PortDirection direction, bool midi);
~Port();
- std::string name() const;
- PortDirection direction() const;
+ std::string name() const { return name_; }
+ PortDirection direction() const { return direction_; }
// True if this port is a MIDI port, instead of another kind of ALSA port.
- bool midi() const;
+ bool midi() const { return midi_; }
private:
const std::string name_;
@@ -244,8 +244,8 @@ class MIDI_EXPORT MidiManagerAlsa final : public MidiManager {
Client(const std::string& name, snd_seq_client_type_t type);
~Client();
- std::string name() const;
- snd_seq_client_type_t type() const;
+ std::string name() const { return name_; }
+ snd_seq_client_type_t type() const { return type_; }
void AddPort(int addr, scoped_ptr<Port> port);
void RemovePort(int addr);
PortMap::const_iterator begin() const;
« no previous file with comments | « no previous file | media/midi/midi_manager_alsa.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698