Issue 1145533004: Eliminate some trivial accessors and use "= default" for some required destructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1145533004: Eliminate some trivial accessors and use "= default" for some required destructors (Closed)

Created:
5 years, 7 months ago by Adam Goode

Modified:
5 years, 7 months ago

Reviewers:
Takashi Toyoshima

CC:
chromium-reviews, feature-media-reviews_chromium.org, toyoshim+midi_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Eliminate some trivial accessors and use "= default" for some required destructors Committed: https://crrev.com/ef99191240af78a81c19f34cf39c5097208246b7 Cr-Commit-Position: refs/heads/master@{#330726}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -46 lines)			Patch
	M	media/midi/midi_manager_alsa.h	View		3 chunks	+6 lines, -6 lines	0 comments	Download
	M	media/midi/midi_manager_alsa.cc	View		6 chunks	+7 lines, -40 lines	0 comments	Download

Total messages: 7 (2 generated)

Takashi Toyoshima

Ah, that's nice to use '= default' in favor of welcomed C++11 features. LGTM.

5 years, 7 months ago (2015-05-20 03:49:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145533004/1

5 years, 7 months ago (2015-05-20 11:43:39 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 12:23:21 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ef99191240af78a81c19f34cf39c5097208246b7
Cr-Commit-Position: refs/heads/master@{#330726}