Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2319)

Unified Diff: chrome/browser/net/pref_proxy_config_tracker_impl.h

Issue 1145513004: Record UMA when googlezip proxies are removed from the proxy config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added comment about bitwise ORs Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/net/pref_proxy_config_tracker_impl.h
diff --git a/chrome/browser/net/pref_proxy_config_tracker_impl.h b/chrome/browser/net/pref_proxy_config_tracker_impl.h
index f09cfef3b799fcf47ae864080232963f55958eec..a98b37d30a00fb672351c19fec626300c595cf2d 100644
--- a/chrome/browser/net/pref_proxy_config_tracker_impl.h
+++ b/chrome/browser/net/pref_proxy_config_tracker_impl.h
@@ -81,6 +81,16 @@ class ChromeProxyConfigService
// ChromeProxyConfigService::UpdateProxyConfig to use.
class PrefProxyConfigTrackerImpl : public PrefProxyConfigTracker {
public:
+ // Enum values that can be reported for the
+ // Net.PrefProxyConfig.GooglezipProxyRemovalResult histogram. These values
+ // must be kept in sync with their counterparts in histograms.xml. Visible
+ // here for testing purposes.
+ enum GooglezipProxyRemovalResult {
+ GOOGLEZIP_PROXY_REMOVAL_RESULT_NOT_FOUND = 0,
+ GOOGLEZIP_PROXY_REMOVAL_RESULT_FOUND_AND_REMOVED,
+ GOOGLEZIP_PROXY_REMOVAL_RESULT_MAX
+ };
+
explicit PrefProxyConfigTrackerImpl(PrefService* pref_service);
~PrefProxyConfigTrackerImpl() override;

Powered by Google App Engine
This is Rietveld 408576698