Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 1145473006: Disable failing TextEliderTest.* and FontListTest.* (Closed)

Created:
5 years, 7 months ago by pkotwicz
Modified:
5 years, 7 months ago
Reviewers:
msw, jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable failing TextEliderTest.* and FontListTest.* This CL: - disables the remaining TextEliderTest.* on Android - disables more failing FontListTest.* on Android BUG=338784, 489354 Committed: https://crrev.com/85fd1d9526b59acbac9cdb04cb0adb2af1be0b55 Cr-Commit-Position: refs/heads/master@{#330749}

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+119 lines, -33 lines) Patch
M build/android/pylib/gtest/filter/gfx_unittests_disabled View 1 1 chunk +0 lines, -17 lines 0 comments Download
M ui/gfx/font_list_unittest.cc View 1 2 11 chunks +83 lines, -11 lines 0 comments Download
M ui/gfx/text_elider_unittest.cc View 1 5 chunks +36 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
pkotwicz
jbudorick@ can you please take a look at the changes in build/android/pylib/gtest/filter/gfx_unittests_disabled msw@ can you ...
5 years, 7 months ago (2015-05-18 17:57:11 UTC) #2
jbudorick
I don't agree with moving the text elider test disabling from the code to the ...
5 years, 7 months ago (2015-05-18 18:10:05 UTC) #4
pkotwicz
jbudorick@ can you please take a look? I have moved the disabling into the test ...
5 years, 7 months ago (2015-05-18 19:14:44 UTC) #5
jbudorick
Thanks for moving all of the FontListTest disables out of there! https://codereview.chromium.org/1145473006/diff/40001/ui/gfx/font_list_unittest.cc File ui/gfx/font_list_unittest.cc (right): ...
5 years, 7 months ago (2015-05-18 19:17:56 UTC) #6
pkotwicz
jbudorick@ can you please take another look? https://codereview.chromium.org/1145473006/diff/40001/ui/gfx/font_list_unittest.cc File ui/gfx/font_list_unittest.cc (right): https://codereview.chromium.org/1145473006/diff/40001/ui/gfx/font_list_unittest.cc#newcode93 ui/gfx/font_list_unittest.cc:93: #if !defined(OS_ANDROID) ...
5 years, 7 months ago (2015-05-18 20:59:06 UTC) #7
jbudorick
build/android/ lgtm
5 years, 7 months ago (2015-05-19 21:53:59 UTC) #8
jbudorick
On 2015/05/19 21:53:59, jbudorick wrote: > build/android/ lgtm and thanks for the cleanup!
5 years, 7 months ago (2015-05-19 21:54:09 UTC) #9
msw
lgtm
5 years, 7 months ago (2015-05-19 21:57:57 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145473006/60001
5 years, 7 months ago (2015-05-20 15:40:45 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-20 16:36:32 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 16:37:27 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/85fd1d9526b59acbac9cdb04cb0adb2af1be0b55
Cr-Commit-Position: refs/heads/master@{#330749}

Powered by Google App Engine
This is Rietveld 408576698