Don't use a deleted task runner on Mandoline shutdown.

Don't use a deleted task runner on Mandoline shutdown.

If one of the core services apps called terminate, the thread won't be valid.

This is split off https://codereview.chromium.org/1139673003

BUG=484234
Committed: https://crrev.com/dd2b261f352510b14ca444a7d834da30c6ae6444
Cr-Commit-Position: refs/heads/master@{#330410}

[jam, 2015-05-18 16:16:55]

jam@chromium.org changed reviewers:
+ sky@chromium.org

[sky, 2015-05-18 16:53:14]

https://codereview.chromium.org/1145473005/diff/1/mandoline/services/core_ser...
File mandoline/services/core_services/core_services_application_delegate.cc
(right):

https://codereview.chromium.org/1145473005/diff/1/mandoline/services/core_ser...
mandoline/services/core_services/core_services_application_delegate.cc:75: if
(!IsRunning())
Do we get here because CoreServicesApplicationDelegate is not removing a thread
from application_threads_ once the app quits? Should we be removing the thread
from application_threads_ in that case?

[jam, 2015-05-18 17:33:48]

https://codereview.chromium.org/1145473005/diff/1/mandoline/services/core_ser...
File mandoline/services/core_services/core_services_application_delegate.cc
(right):

https://codereview.chromium.org/1145473005/diff/1/mandoline/services/core_ser...
mandoline/services/core_services/core_services_application_delegate.cc:75: if
(!IsRunning())
On 2015/05/18 16:53:14, sky wrote:
> Do we get here because CoreServicesApplicationDelegate is not removing a
thread
> from application_threads_ once the app quits? 

Yep

> Should we be removing the thread from application_threads_ in that case?

I wasn't handling the core-app-restart case which would need this; I was punting
until we need it. but you're right, we should just handle it now anyways until
waiting. I added support.

[sky, 2015-05-18 19:15:58]

LGTM

https://codereview.chromium.org/1145473005/diff/20001/mandoline/services/core...
File mandoline/services/core_services/core_services_application_delegate.cc
(right):

https://codereview.chromium.org/1145473005/diff/20001/mandoline/services/core...
mandoline/services/core_services/core_services_application_delegate.cc:119: for
(size_t i = 0; i < application_threads_.size(); ++i) {
std::find?

[jam, 2015-05-18 20:15:39]

https://codereview.chromium.org/1145473005/diff/20001/mandoline/services/core...
File mandoline/services/core_services/core_services_application_delegate.cc
(right):

https://codereview.chromium.org/1145473005/diff/20001/mandoline/services/core...
mandoline/services/core_services/core_services_application_delegate.cc:119: for
(size_t i = 0; i < application_threads_.size(); ++i) {
On 2015/05/18 19:15:58, sky wrote:
> std::find?

Done.

[jam, 2015-05-18 20:15:45]

The CQ bit was checked by jam@chromium.org

[jam, 2015-05-18 20:15:45]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1145473005/#ps40001
(title: "review comments")

[commit-bot: I haz the power, 2015-05-18 20:17:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1145473005/40001

[commit-bot: I haz the power, 2015-05-18 20:47:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-18 22:42:47]

Patchset 3 (id:??) landed as
https://crrev.com/dd2b261f352510b14ca444a7d834da30c6ae6444
Cr-Commit-Position: refs/heads/master@{#330410}