Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1145473002: Android scripts: add --verbose, fix missing 'source android_setup' (Closed)

Created:
5 years, 7 months ago by borenet
Modified:
5 years, 7 months ago
Reviewers:
hal.canary, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Android scripts: add --verbose, fix missing 'source android_setup' BUG=skia:3836 TBR=djsollen Committed: https://skia.googlesource.com/skia/+/7ae68a8f8d5b26cb945dbf8147eb343a59c22b40

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M platform_tools/android/bin/android_kill_skia View 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/android_setup.sh View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
borenet
5 years, 7 months ago (2015-05-14 13:21:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145473002/1
5 years, 7 months ago (2015-05-14 13:31:08 UTC) #4
borenet
Committing TBR since this may be contributing to flakiness on the Android bots. +Hal for ...
5 years, 7 months ago (2015-05-14 13:32:38 UTC) #6
hal.canary
lgtm
5 years, 7 months ago (2015-05-14 13:33:26 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 13:37:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7ae68a8f8d5b26cb945dbf8147eb343a59c22b40

Powered by Google App Engine
This is Rietveld 408576698