Issue 1145463003: Revert of [bindings] Remove custom setter used in CSSStyleDeclaration

Issue 1145463003: Revert of [bindings] Remove custom setter used in CSSStyleDeclaration (Closed)

Created:
5 years, 7 months ago by vivekg

Modified:
5 years, 7 months ago

Reviewers:
haraken, vivekg_samsung

CC:
darktears, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-css, blink-reviews-style_chromium.org, Inactive, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, vivekg_samsung

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Revert of [bindings] Remove custom setter used in CSSStyleDeclaration (patchset #1 id:1 of https://codereview.chromium.org/1119653002/) Reason for revert: Reverting due to the dromeo.jslibstylejquery regression BUG=483448 Original issue's description: > [bindings] Remove custom setter used in CSSStyleDeclaration > > This CL is a first in the series of CSSStyleDeclaration's usage of custom bindings. > Here we migrate the helper methods required from the custom bindings as is. > These duplicate helper functions would be eventually removed from the custom binding as we > finish the removal. > > BUG=345519 > > R=haraken@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194718 TBR=haraken@chromium.org,vivek.vg@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=345519 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195363

Patch Set 1 #

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+20 lines, -132 lines)			Patch
M	Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp	View	1 chunk	+19 lines, -0 lines	0 comments	Download
M	Source/core/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/css/CSSStyleDeclaration.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	Source/core/css/CSSStyleDeclaration.cpp	View	1 chunk	+0 lines, -128 lines	0 comments	Download
M	Source/core/css/CSSStyleDeclaration.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vivekg

Created Revert of [bindings] Remove custom setter used in CSSStyleDeclaration

5 years, 7 months ago (2015-05-14 16:28:46 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145463003/1

5 years, 7 months ago (2015-05-14 16:29:00 UTC) #2

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195363

5 years, 7 months ago (2015-05-14 16:29:35 UTC) #3

Message was sent while issue was closed.

LGTM.

Thanks for these reverts. Let's see how it goes.

Expand Messages | Collapse Messages