Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1145463002: Plumb manifest fetching through WebTestDelegate interface (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
Mike West
CC:
chromium-reviews, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plumb manifest fetching through WebTestDelegate interface BUG=478250 R=mkwst@chromium.org Committed: https://crrev.com/91bc3df1aedc526fadf396f6c9d82b8e1d390ae4 Cr-Commit-Position: refs/heads/master@{#329823}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -4 lines) Patch
M content/shell/renderer/layout_test/blink_test_runner.h View 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/renderer/layout_test/blink_test_runner.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/shell/renderer/test_runner/test_runner.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M content/shell/renderer/test_runner/web_test_delegate.h View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-14 05:11:56 UTC) #1
Mike West
On 2015/05/14 at 05:11:56, jochen wrote: > LGTM. Would it be reasonable to add a ...
5 years, 7 months ago (2015-05-14 09:29:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145463002/1
5 years, 7 months ago (2015-05-14 09:43:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 09:46:18 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 09:47:09 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/91bc3df1aedc526fadf396f6c9d82b8e1d390ae4
Cr-Commit-Position: refs/heads/master@{#329823}

Powered by Google App Engine
This is Rietveld 408576698