Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 1145453004: Sync: Remove VerifyLocalIdToUpdate (Closed)

Created:
5 years, 7 months ago by stanisc
Modified:
5 years, 7 months ago
Reviewers:
maniscalco
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync: Remove VerifyLocalIdToUpdate. Now that 362467 is fixed, VerifyLocalIdToUpdate function is no longer needed and should be removed. This function was added two months ago to help diagnose the root cause. I've verified that there are no new crash dumps with VerifyLocalIdToUpdate since 44.0.2401.0. BUG=362467 Committed: https://crrev.com/c51d1eb924fd2580a44eb24614295f080f8b4bee Cr-Commit-Position: refs/heads/master@{#330455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -48 lines) Patch
M sync/engine/syncer_util.cc View 5 chunks +0 lines, -48 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stanisc
PTAL. This is cleanup change to complete 362467.
5 years, 7 months ago (2015-05-18 22:38:48 UTC) #2
maniscalco
lgtm
5 years, 7 months ago (2015-05-18 23:37:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145453004/1
5 years, 7 months ago (2015-05-19 00:05:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 00:09:28 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 00:10:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c51d1eb924fd2580a44eb24614295f080f8b4bee
Cr-Commit-Position: refs/heads/master@{#330455}

Powered by Google App Engine
This is Rietveld 408576698