Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1145453003: Record time between selecting items from the Ash app list (Closed)

Created:
5 years, 7 months ago by tdanderson
Modified:
5 years, 7 months ago
Reviewers:
oshima, Mark P, bruthig
CC:
chromium-reviews, tapted, sadrul, Matt Giuca, tfarina, asvitkine+watch_chromium.org, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Record time between selecting items from the Ash app list Add the histogram Ash.AppList.TimeBetweenTaskSwitches to record the time between selecting items from the app list (launcher) in Ash. BUG=478933 TEST=TaskSwitchMetricsRecorderTest.VerifyTaskSwitchesFromAppListAreRecorded Committed: https://crrev.com/15ddc12eac4d0d490001bdfee8debaeac341f917 Cr-Commit-Position: refs/heads/master@{#330276}

Patch Set 1 #

Patch Set 2 : reworded description #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M ash/metrics/task_switch_metrics_recorder.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M ash/metrics/task_switch_metrics_recorder_unittest.cc View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/app_list/app_list_controller_ash.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
tdanderson
Ben, please take a first look.
5 years, 7 months ago (2015-05-15 17:12:05 UTC) #2
bruthig
lgtm with nit
5 years, 7 months ago (2015-05-15 17:14:47 UTC) #3
tdanderson
oshima@, can you please look at ash/ and chrome/ ? mpearson@, can you please look ...
5 years, 7 months ago (2015-05-15 18:50:02 UTC) #5
Mark P
histograms.xml lgtm
5 years, 7 months ago (2015-05-15 19:20:57 UTC) #6
oshima
lgtm
5 years, 7 months ago (2015-05-15 20:47:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145453003/40001
5 years, 7 months ago (2015-05-16 02:03:57 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-16 03:15:16 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:31:22 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/15ddc12eac4d0d490001bdfee8debaeac341f917
Cr-Commit-Position: refs/heads/master@{#330276}

Powered by Google App Engine
This is Rietveld 408576698