Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2550)

Unified Diff: Source/platform/heap/ThreadState.h

Issue 1145423009: Oilpan: simplify away StoppingOtherThreads pseudo GCState. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: revert 'explicit' removal Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/heap/SafePoint.h ('k') | Source/platform/heap/ThreadState.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/heap/ThreadState.h
diff --git a/Source/platform/heap/ThreadState.h b/Source/platform/heap/ThreadState.h
index 5d93b22443d6fdd4070326c53671b7770a675050..d44c39c32daa7d57547ba208aebe2b50c0593265 100644
--- a/Source/platform/heap/ThreadState.h
+++ b/Source/platform/heap/ThreadState.h
@@ -196,7 +196,6 @@ public:
IdleGCScheduled,
PreciseGCScheduled,
FullGCScheduled,
- StoppingOtherThreads,
GCRunning,
EagerSweepScheduled,
LazySweepScheduled,
@@ -356,7 +355,11 @@ public:
void leaveNoAllocationScope() { m_noAllocationCount--; }
bool isGCForbidden() const { return m_gcForbiddenCount; }
void enterGCForbiddenScope() { m_gcForbiddenCount++; }
- void leaveGCForbiddenScope() { m_gcForbiddenCount--; }
+ void leaveGCForbiddenScope()
+ {
+ ASSERT(m_gcForbiddenCount > 0);
+ m_gcForbiddenCount--;
+ }
bool sweepForbidden() const { return m_sweepForbidden; }
void prepareRegionTree();
@@ -563,7 +566,6 @@ public:
}
void leaveGCForbiddenScopeIfNeeded(GarbageCollectedMixinConstructorMarker* gcMixinMarker)
{
- ASSERT(m_gcForbiddenCount > 0);
if (m_gcMixinMarker == gcMixinMarker) {
leaveGCForbiddenScope();
m_gcMixinMarker = nullptr;
« no previous file with comments | « Source/platform/heap/SafePoint.h ('k') | Source/platform/heap/ThreadState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698