Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: go/src/infra/tools/cipd/common/common.go

Issue 1145423002: cipd: Client can resolve tags to instance IDs. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: cipd-resolve-version Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: go/src/infra/tools/cipd/common/common.go
diff --git a/go/src/infra/tools/cipd/common/common.go b/go/src/infra/tools/cipd/common/common.go
index 338cf05d1240237639ac42a41d78d03007607dd6..0f4c3caf1fee28f6f8da23d2e7f9415152d88e4d 100644
--- a/go/src/infra/tools/cipd/common/common.go
+++ b/go/src/infra/tools/cipd/common/common.go
@@ -78,3 +78,15 @@ func ValidateInstanceTag(t string) error {
}
return nil
}
+
+// ValidateInstanceVersion return error if a string doesn't look like
+// an instance ID or an instance tag.
+func ValidateInstanceVersion(v string) error {
+ if err := ValidateInstanceID(v); err == nil {
nodir 2015/05/21 17:07:48 if ValidateInstanceID(v) == nil && ValidateInstanc
Vadim Sh. 2015/05/21 18:00:37 :) Done.
+ return nil
+ }
+ if err := ValidateInstanceTag(v); err == nil {
+ return nil
+ }
+ return fmt.Errorf("Bad version (not an instance ID or a tag): %s", v)
+}

Powered by Google App Engine
This is Rietveld 408576698