Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(964)

Issue 1145383005: Add Vagrant support (Closed)

Created:
5 years, 6 months ago by wychen
Modified:
5 years, 6 months ago
Reviewers:
nyquist
Base URL:
git@github.com:chromium/dom-distiller.git@chrome
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Vagrant support Vagrant is helpful if you want to develop on an unsupported system, or would rather not touch the system too much. TEST=vagrant up && vagrant ssh -c 'cd /vagrant && ant test' R=nyquist@chromium.org Committed: 61e72260be6a3014d2f0b897f20a1a65918f8c58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -1 line) Patch
M README.md View 2 chunks +22 lines, -1 line 0 comments Download
A Vagrantfile View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
wychen
PTAL
5 years, 6 months ago (2015-05-27 23:23:42 UTC) #2
nyquist
lgtm
5 years, 6 months ago (2015-06-01 21:05:13 UTC) #3
wychen
5 years, 6 months ago (2015-06-05 23:26:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
61e72260be6a3014d2f0b897f20a1a65918f8c58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698