Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 1145373002: [Cleanup] Fix pronouns in comments. (Closed)

Created:
5 years, 7 months ago by groby-ooo-7-16
Modified:
5 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@pronoun-x11
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Fix pronouns in comments. Replacing "he/she" with "they". BUG=none R=dbeam@chromium.org Committed: https://crrev.com/1721c275751cfd2d04020f190f42f6f2359d4b5a Cr-Commit-Position: refs/heads/master@{#330886}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Apply comment nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
groby-ooo-7-16
5 years, 7 months ago (2015-05-21 00:00:04 UTC) #1
Dan Beam
lgtm https://codereview.chromium.org/1145373002/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc File chrome/browser/ui/webui/options/browser_options_handler.cc (right): https://codereview.chromium.org/1145373002/diff/1/chrome/browser/ui/webui/options/browser_options_handler.cc#newcode1135 chrome/browser/ui/webui/options/browser_options_handler.cc:1135: // arguably want to be notified when that ...
5 years, 7 months ago (2015-05-21 00:05:58 UTC) #2
groby-ooo-7-16
Don't you wish you could edit patches inline...? :)
5 years, 7 months ago (2015-05-21 00:11:59 UTC) #3
groby-ooo-7-16
5 years, 7 months ago (2015-05-21 00:12:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145373002/20001
5 years, 7 months ago (2015-05-21 00:13:38 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-21 04:37:12 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:41:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1721c275751cfd2d04020f190f42f6f2359d4b5a
Cr-Commit-Position: refs/heads/master@{#330886}

Powered by Google App Engine
This is Rietveld 408576698