Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 1145343008: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/ssl (Closed)

Created:
5 years, 6 months ago by HariS
Modified:
5 years, 6 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in net/ssl BUG=457697 Committed: https://crrev.com/8a1db1e25199eb1203ba903edf66540b92fc3609 Cr-Commit-Position: refs/heads/master@{#332550}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/ssl/default_channel_id_store.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
HariS
Please review the change.
5 years, 6 months ago (2015-06-02 09:20:40 UTC) #2
mmenke
LGTM. You can do more than one of these in one CL, you know. :)
5 years, 6 months ago (2015-06-02 13:20:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145343008/1
5 years, 6 months ago (2015-06-03 03:03:51 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 04:17:51 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 04:18:51 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8a1db1e25199eb1203ba903edf66540b92fc3609
Cr-Commit-Position: refs/heads/master@{#332550}

Powered by Google App Engine
This is Rietveld 408576698