sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart - Issue 11453032: Reapply class/method/field minification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

Issue 11453032: Reapply class/method/field minification (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Review feedback Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/js_backend.dart » ('j') | sdk/lib/_internal/compiler/implementation/js_backend/namer.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

index 0b6c0f542924bf24f6acfabe93ff5c05d366f62c..9aec2bc93d016807a66ac52cfa838ac4368803a0 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart

@@ -39,7 +39,7 @@ function(cls, constructor, prototype) {

// isolateProperties themselves.

return """

function(oldIsolate) {

- var isolateProperties = oldIsolate.${namer.ISOLATE_PROPERTIES};

+ var isolateProperties = oldIsolate.${namer.isolatePropertiesName};

function Isolate() {

for (var staticName in isolateProperties) {

if (Object.prototype.hasOwnProperty.call(isolateProperties, staticName)) {

@@ -54,7 +54,7 @@ function(oldIsolate) {

}

Isolate.prototype = oldIsolate.prototype;

Isolate.prototype.constructor = Isolate;

- Isolate.${namer.ISOLATE_PROPERTIES} = isolateProperties;

+ Isolate.${namer.isolatePropertiesName} = isolateProperties;

return Isolate;

}""";

}

@@ -108,6 +108,7 @@ $classesCollector.$mangledName = {'': function $mangledName(self, target) {

List<String> fields = <String>[];

visitClassFields(classElement, (Element member,

String name,

+ String accessorName,

bool needsGetter,

bool needsSetter,

bool needsCheckedSetter) {