Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1145303004: Pass browser user agent to android DownloadManager if no override UA is present. (Closed)

Created:
5 years, 7 months ago by qinmin
Modified:
5 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass browser user agent to android DownloadManager if no override UA is present. user-agent may not present in URlRequest->extra_request_headers() if the field is not overriden. In this case, we should pass browser's UA to the android download manager. We have done something similar in MediaPlayerBridge too. BUG=488444 Committed: https://crrev.com/7c43b0968c2063ddeb6fdbdddb52dce9209f31bb Cr-Commit-Position: refs/heads/master@{#330861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M content/browser/android/download_controller_android_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
qinmin
PTAL
5 years, 7 months ago (2015-05-20 23:35:44 UTC) #2
Ted C
lgtm
5 years, 7 months ago (2015-05-20 23:38:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145303004/1
5 years, 7 months ago (2015-05-20 23:41:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 00:35:49 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 00:36:41 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7c43b0968c2063ddeb6fdbdddb52dce9209f31bb
Cr-Commit-Position: refs/heads/master@{#330861}

Powered by Google App Engine
This is Rietveld 408576698