Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Unified Diff: sdk/lib/html/src/Isolates.dart

Issue 11453027: Fixed a lot of dartanalyzer static analysis issues with the html lib. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/html/src/Isolates.dart
diff --git a/sdk/lib/html/src/Isolates.dart b/sdk/lib/html/src/Isolates.dart
index fe0ea4b0373a53cbb8e927d0c7fc892b8bad02b2..e4cd7708bf95c0c7ad1f3e173e66b6ab499387a8 100644
--- a/sdk/lib/html/src/Isolates.dart
+++ b/sdk/lib/html/src/Isolates.dart
@@ -26,9 +26,13 @@ class _JsSerializer extends _Serializer {
ReceivePortSync._isolateId, x._receivePort._portId ];
}
+ visitSendPort(SendPort x) {
+ throw new UnimplementedError('Asynchronous send port not yet implemented.');
+ }
+
visitRemoteSendPortSync(_RemoteSendPortSync x) {
return [ 'sendport', 'dart',
Anton Muhin 2012/12/06 14:50:40 that probably fits a single line now. Maybe even
- x._receivePort._isolateId, x._receivePort._portId ];
+ x._isolateId, x._portId ];
}
}
@@ -86,7 +90,7 @@ class _RemoteSendPortSync implements SendPortSync {
}
static _call(int isolateId, int portId, var message) {
- var target = 'dart-port-$isolateId-$portId';
+ var target = 'dart-port-$isolateId-$portId';
// TODO(vsm): Make this re-entrant.
// TODO(vsm): Set this up set once, on the first call.
var source = '$target-result';
@@ -151,13 +155,13 @@ class ReceivePortSync {
static int get _isolateId {
// TODO(vsm): Make this coherent with existing isolate code.
if (_cachedIsolateId == null) {
- _cachedIsolateId = _getNewIsolateId();
+ _cachedIsolateId = _getNewIsolateId();
}
return _cachedIsolateId;
}
static String _getListenerName(isolateId, portId) =>
- 'dart-port-$isolateId-$portId';
+ 'dart-port-$isolateId-$portId';
String get _listenerName => _getListenerName(_isolateId, _portId);
void receive(callback(var message)) {

Powered by Google App Engine
This is Rietveld 408576698