Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: cc/tile_manager.h

Issue 11453014: Implement the logic to kick off image decoding jobs for TileManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: moving pending_pixel_refs to the persistent section Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/tile_manager.h
diff --git a/cc/tile_manager.h b/cc/tile_manager.h
index 31826aedce7839a77862f3614bbe3766b03df03d..39c5dfc93d7d1c511a9e29258bdc8d37b97a8a2b 100644
--- a/cc/tile_manager.h
+++ b/cc/tile_manager.h
@@ -5,6 +5,7 @@
#ifndef CC_TILE_MANAGER_H_
#define CC_TILE_MANAGER_H_
+#include <list>
#include <queue>
#include <vector>
@@ -53,6 +54,8 @@ class CC_EXPORT ManagedTileState {
scoped_ptr<ResourcePool::Resource> resource;
bool resource_is_being_initialized;
bool contents_swizzled;
+ bool has_image_decoding_info;
+ std::list<skia::LazyPixelRef*> pending_pixel_refs;
reveman 2012/12/11 01:35:42 nit: can you make it obvious that these two member
qinmin 2012/12/11 04:30:15 Done.
// Ephemeral state, valid only during Manage.
TileManagerBin bin;
@@ -91,7 +94,7 @@ class CC_EXPORT TileManager {
void FreeResourcesForTile(Tile*);
void ScheduleManageTiles();
void ScheduleCheckForCompletedSetPixels();
- void DispatchMoreRasterTasks();
+ void DispatchMoreTasks();
void DispatchOneRasterTask(RasterThread*, scoped_refptr<Tile>);
void OnRasterTaskCompleted(
scoped_refptr<Tile>,
@@ -99,6 +102,12 @@ class CC_EXPORT TileManager {
scoped_refptr<PicturePileImpl>,
RenderingStats*);
void DidFinishTileInitialization(Tile*);
+ bool HasImageDecodingTasks(Tile*);
+ void OnImageDecodingTaskCompleted(scoped_refptr<Tile>, uint32_t);
+ void DispatchOneImageDecodingTask(
+ RasterThread*, scoped_refptr<Tile>, skia::LazyPixelRef*);
+ void GetImageInformationForTile(Tile*);
+ RasterThread* GetFreeRasterThread();
TileManagerClient* client_;
scoped_ptr<ResourcePool> resource_pool_;
@@ -111,6 +120,13 @@ class CC_EXPORT TileManager {
TileVector tiles_;
TileVector tiles_that_need_to_be_rasterized_;
+ typedef std::list<Tile*> TileList;
+ // Tiles that are has image decoding tasks.
reveman 2012/12/11 01:35:42 I guess the proper name for the list is tiles_that
qinmin 2012/12/11 04:30:15 Done.
+ TileList tiles_have_image_decoding_tasks_;
reveman 2012/12/11 01:35:42 nit: tiles_that_have_image_decoding_tasks_ or tile
qinmin 2012/12/11 04:30:15 Done.
+
+ typedef base::hash_map<uint32_t, skia::LazyPixelRef*> PixelRefMap;
+ PixelRefMap pending_decode_tasks_;
+
typedef std::queue<scoped_refptr<Tile> > TileQueue;
TileQueue tiles_with_pending_set_pixels_;
« no previous file with comments | « cc/picture_pile_impl.cc ('k') | cc/tile_manager.cc » ('j') | cc/tile_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698