Re-proc SkBlitRow::Color32 for ARM.

Re-proc SkBlitRow::Color32 for ARM.

This is a spiritual revert of http://crrev.com/1104183004.

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/4e13a23d8f720e17660f26657b45b89fe4339004

Committed: https://skia.googlesource.com/skia/+/051a51ec32549078a65ade19e42df0b9d9f9a3ff

[mtklein, 2015-05-21 19:54:32]

The CQ bit was checked by mtklein@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-05-21 19:54:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1145283003/40001

[mtklein_C, 2015-05-21 20:02:28]

mtklein@chromium.org changed reviewers:
+ reed@google.com
- mtklein@google.com

[reed1, 2015-05-21 21:15:04]

https://codereview.chromium.org/1145283003/diff/40001/src/opts/SkBlitRow_opts...
File src/opts/SkBlitRow_opts_arm.cpp (right):

https://codereview.chromium.org/1145283003/diff/40001/src/opts/SkBlitRow_opts...
src/opts/SkBlitRow_opts_arm.cpp:394: #define sk_blitrow_color32_arm NULL
Why the #define?

[mtklein, 2015-05-21 21:30:21]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-05-21 21:30:22]

https://codereview.chromium.org/1145283003/diff/40001/src/opts/SkBlitRow_opts...
File src/opts/SkBlitRow_opts_arm.cpp (right):

https://codereview.chromium.org/1145283003/diff/40001/src/opts/SkBlitRow_opts...
src/opts/SkBlitRow_opts_arm.cpp:394: #define sk_blitrow_color32_arm NULL
On 2015/05/21 21:15:03, reed1 wrote:
> Why the #define?

Ah, this is SK_ARM_NEON_WRAP being cute.  It basically expands like this:

SK_ARM_NEON_WRAP(foo)  ~~~> return we_have_runtime_neon() ? foo_neon : foo

So this is the idiom for 'return sk_blitrow_color32_arm_neon if we have NEON,
otherwise return NULL'.

[reed1, 2015-05-21 21:32:30]

GACK!

lgtm

(can we some day find a less obscure way to handle neon procs?)

[mtklein, 2015-05-21 21:33:36]

> (can we some day find a less obscure way to handle neon procs?)

Huh.  Yes maybe.  Good idea.  I hadn't thought of that...

[mtklein, 2015-05-21 21:33:41]

The CQ bit was unchecked by mtklein@google.com

[mtklein, 2015-05-21 21:33:44]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-05-21 21:34:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1145283003/40001

[commit-bot: I haz the power, 2015-05-21 21:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-21 21:55:20]

Try jobs failed on following builders:
  Build-Mac10.8-Clang-x86_64-Release-Trybot on client.skia.compile
(JOB_TIMED_OUT, no build URL)

[mtklein, 2015-05-22 00:14:04]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2015-05-22 00:14:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1145283003/40001

[commit-bot: I haz the power, 2015-05-22 00:14:58]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4e13a23d8f720e17660f26657b45b89fe4339004

[mtklein, 2015-05-22 12:51:12]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1157633003/ by mtklein@google.com.

The reason for reverting is:
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni....

[mtklein, 2015-05-22 13:02:01]

The CQ bit was checked by mtklein@google.com

[mtklein, 2015-05-22 13:02:02]

The patchset sent to the CQ was uploaded after l-g-t-m from reed@google.com
Link to the patchset: https://codereview.chromium.org/1145283003/#ps60001
(title: "ARM builds may be using _opts_none.cpp (iOS)")

[commit-bot: I haz the power, 2015-05-22 13:02:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1145283003/60001

[commit-bot: I haz the power, 2015-05-22 13:08:32]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/051a51ec32549078a65ade19e42df0b9d9f9a3ff