Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1145283002: Use short array syntax in method signatures (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Address comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/runtime/dart_runtime.js ('k') | test/browser/runtime_tests.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 8b46f8c86225157c3f6678f58ddac5a59fbd8a83..0bc0ad72faf377df2fcc079c8c5f16f0218b93e9 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -599,8 +599,9 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
var unary = node.parameters.parameters.isEmpty;
var memberName = _emitMemberName(name,
type: cType, unary: unary, isStatic: node.isStatic);
+ var parts = _emitFunctionTypeParts(element.type);
var property =
- new JS.Property(memberName, _emitTypeName(element.type));
+ new JS.Property(memberName, new JS.ArrayInitializer(parts));
if (node.isStatic) {
tStatics.add(property);
sNames.add(memberName);
« no previous file with comments | « lib/runtime/dart_runtime.js ('k') | test/browser/runtime_tests.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698