lib/src/codegen/js_codegen.dart - Issue 1145283002: Use short array syntax in method signatures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1145283002: Use short array syntax in method signatures (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/codegen/js_codegen.dart

diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart

index 1808bf3a1e50ad3dd4710dcfaa2d84b77efaee76..6cfe4d9e6280c6df9036497ebf5b310b2f2fbf5f 100644

--- a/lib/src/codegen/js_codegen.dart

+++ b/lib/src/codegen/js_codegen.dart

@@ -595,8 +595,9 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {

var unary = node.parameters.parameters.isEmpty;

var memberName = _emitMemberName(name,

type: cType, unary: unary, isStatic: node.isStatic);

+ var parts = _emitFunctionTypeParts(element.type);

var property =

- new JS.Property(memberName, _emitTypeName(element.type));

+ new JS.Property(memberName, new JS.ArrayInitializer(parts));

if (node.isStatic) {

tStatics.add(property);

sNames.add(memberName);