Use short array syntax in method signatures

Use short array syntax in method signatures.

This follows up on a suggestion from jmesserly to use a shorter syntax in methods signatures.  Replaces:

dart.functionType(t, [t0,..., tn], extras)

with

[t, [t0, ..., tn], extras]

BUG=
R=jmesserly@google.com, vsm@google.com

Committed: https://github.com/dart-lang/dev_compiler/commit/00ad0a1ef746252580094fd0cf5df6b0622fb2b2

[Leaf, 2015-05-20 19:35:27]

leafp@google.com changed reviewers:
+ jmesserly@google.com, vsm@google.com

[Leaf, 2015-05-20 19:36:40]

Take a look, see what you guys think of this shorter syntax.  Note that nested
function types still use the explicit representation.  We could consider
representing all function types like this (at least externally, we could still
choose to use a different representation internally).

[Jennifer Messerly, 2015-05-20 19:47:34]

lgtm ... stretch goal, change order?

    add: [[E], core.bool],

since we can't put the return type on the left side of the name, that seems more
natural ... it's kind of like:

    var addToSet = (element) => ...;

https://codereview.chromium.org/1145283002/diff/1/lib/runtime/dart_runtime.js
File lib/runtime/dart_runtime.js (right):

https://codereview.chromium.org/1145283002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1007: let sig = functionType.apply(functionType,
parts);
first arg here could be null right, since there is no `this`? That was the
pattern vsm@ used for Array.apply I think. (Not a big deal tho, it will be
ignored either way.)

https://codereview.chromium.org/1145283002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1042: return functionType.apply(functionType, parts)
indent here is a little off

[vsm, 2015-05-20 22:29:35]

lgtm

https://codereview.chromium.org/1145283002/diff/1/lib/runtime/dart_runtime.js
File lib/runtime/dart_runtime.js (right):

https://codereview.chromium.org/1145283002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1007: let sig = functionType.apply(functionType,
parts);
On 2015/05/20 19:47:34, John Messerly wrote:
> first arg here could be null right, since there is no `this`? That was the
> pattern vsm@ used for Array.apply I think. (Not a big deal tho, it will be
> ignored either way.)

Yes, the first arg to apply is the 'this' pointer.  functionType is top-level,
so cleaner to pass in null.

[Leaf, 2015-05-20 22:52:07]

https://codereview.chromium.org/1145283002/diff/1/lib/runtime/dart_runtime.js
File lib/runtime/dart_runtime.js (right):

https://codereview.chromium.org/1145283002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1007: let sig = functionType.apply(functionType,
parts);
On 2015/05/20 22:29:35, vsm wrote:
> On 2015/05/20 19:47:34, John Messerly wrote:
> > first arg here could be null right, since there is no `this`? That was the
> > pattern vsm@ used for Array.apply I think. (Not a big deal tho, it will be
> > ignored either way.)
> 
> Yes, the first arg to apply is the 'this' pointer.  functionType is top-level,
> so cleaner to pass in null.

Done.

https://codereview.chromium.org/1145283002/diff/1/lib/runtime/dart_runtime.js...
lib/runtime/dart_runtime.js:1042: return functionType.apply(functionType, parts)
On 2015/05/20 19:47:34, John Messerly wrote:
> indent here is a little off

Done.

[Leaf, 2015-05-20 23:11:46]

Committed patchset #2 (id:20001) manually as
00ad0a1ef746252580094fd0cf5df6b0622fb2b2 (presubmit successful).