src/gpu/effects/GrBezierEffect.cpp - Issue 1145273002: Use high precision vertex attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrBezierEffect.cpp

Issue 1145273002: Use high precision vertex attributes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Change other inPosition * fViewMatrix users to highp Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/effects/GrBezierEffect.cpp

diff --git a/src/gpu/effects/GrBezierEffect.cpp b/src/gpu/effects/GrBezierEffect.cpp

index 582558027addb4cbac3916f20989d80573f720c8..8ef3a02ec29a78e2504d661f01527033d669ca4d 100644

--- a/src/gpu/effects/GrBezierEffect.cpp

+++ b/src/gpu/effects/GrBezierEffect.cpp

@@ -200,7 +200,7 @@ GrConicEffect::GrConicEffect(GrColor color, const SkMatrix& viewMatrix, uint8_t

, fCoverageScale(coverage)

, fEdgeType(edgeType) {

this->initClassID<GrConicEffect>();

- fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType));

+ fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType, kHigh_GrSLPrecision));

joshualitt 2015/05/20 20:36:11 newline

Stephen White 2015/05/20 20:47:43 Done.

fInConicCoeffs = &this->addVertexAttrib(Attribute("inConicCoeffs",

kVec4f_GrVertexAttribType));

}

@@ -401,7 +401,7 @@ GrQuadEffect::GrQuadEffect(GrColor color, const SkMatrix& viewMatrix, uint8_t co

, fCoverageScale(coverage)

, fEdgeType(edgeType) {

this->initClassID<GrQuadEffect>();

- fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType));

+ fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType, kHigh_GrSLPrecision));

joshualitt 2015/05/20 20:36:10 newline

Stephen White 2015/05/20 20:47:43 Done.

fInHairQuadEdge = &this->addVertexAttrib(Attribute("inHairQuadEdge",

kVec4f_GrVertexAttribType));

}

@@ -614,7 +614,7 @@ GrCubicEffect::GrCubicEffect(GrColor color, const SkMatrix& viewMatrix,

, fViewMatrix(viewMatrix)

, fEdgeType(edgeType) {

this->initClassID<GrCubicEffect>();

- fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType));

+ fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType, kHigh_GrSLPrecision));

joshualitt 2015/05/20 20:36:10 newline

Stephen White 2015/05/20 20:47:43 Done.

fInCubicCoeffs = &this->addVertexAttrib(Attribute("inCubicCoeffs",

kVec4f_GrVertexAttribType));

}

« src/gpu/GrPrimitiveProcessor.h ('K') | « src/gpu/GrPrimitiveProcessor.h ('k') | src/gpu/effects/GrDistanceFieldGeoProc.cpp » ('j') | src/gpu/effects/GrDistanceFieldGeoProc.cpp » ('J')