src/gpu/GrOvalRenderer.cpp - Issue 1145273002: Use high precision vertex attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrOvalRenderer.cpp

Issue 1145273002: Use high precision vertex attributes. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Change other inPosition * fViewMatrix users to highp Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/GrOvalRenderer.cpp

diff --git a/src/gpu/GrOvalRenderer.cpp b/src/gpu/GrOvalRenderer.cpp

index fe223f0382d7c52eaa1858e9ed9f0c91e10ff358..6406dd635d2063554d18329e2c47454e9e2d5203 100644

--- a/src/gpu/GrOvalRenderer.cpp

+++ b/src/gpu/GrOvalRenderer.cpp

@@ -183,7 +183,7 @@ private:

, fLocalMatrix(localMatrix)

, fUsesLocalCoords(usesLocalCoords) {

this->initClassID<CircleEdgeEffect>();

- fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType));

+ fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType, kHigh_GrSLPrecision));

joshualitt 2015/05/20 20:36:10 newline

Stephen White 2015/05/20 20:47:43 Done.

fInCircleEdge = &this->addVertexAttrib(Attribute("inCircleEdge",

kVec4f_GrVertexAttribType));

fStroke = stroke;

@@ -556,7 +556,7 @@ private:

, fViewMatrix(viewMatrix)

, fUsesLocalCoords(usesLocalCoords) {

this->initClassID<DIEllipseEdgeEffect>();

- fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType));

+ fInPosition = &this->addVertexAttrib(Attribute("inPosition", kVec2f_GrVertexAttribType, kHigh_GrSLPrecision));

joshualitt 2015/05/20 20:36:10 newline

Stephen White 2015/05/20 20:47:43 Done.

fInEllipseOffsets0 = &this->addVertexAttrib(Attribute("inEllipseOffsets0",

kVec2f_GrVertexAttribType));

fInEllipseOffsets1 = &this->addVertexAttrib(Attribute("inEllipseOffsets1",