lib/src/dependency_graph.dart - Issue 1145243013: Check for duplicate library names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/dependency_graph.dart

Issue 1145243013: Check for duplicate library names (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master

Patch Set: Address comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/dependency_graph.dart

diff --git a/lib/src/dependency_graph.dart b/lib/src/dependency_graph.dart

index cb2b62cc0c082e1c9709f3da7b1bc95fb876e305..99e7d0e77aa8c060e80fecd0ec4c7ef354f85372 100644

--- a/lib/src/dependency_graph.dart

+++ b/lib/src/dependency_graph.dart

@@ -511,17 +511,17 @@ const corelibOrder = const [

'dart.collection',

'dart._internal',

'dart.math',

+ 'dart._interceptors',

'dart.async',

'dart._foreign_helper',

'dart._js_embedded_names',

'dart._js_helper',

'dart.isolate',

'dart.typed_data',

+ 'dart._native_typed_data',

'dart._isolate_helper',

'dart._js_primitives',

- 'dart._interceptors',

'dart.convert',

- 'dart._native_typed_data',

// _foreign_helper is not included, as it only defines the JS builtin that

// the compiler handles at compile time.

];

« no previous file with comments | « lib/src/codegen/js_codegen.dart ('k') | test/browser/runtime_tests.js » ('j') | no next file with comments »