Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(8)

Issue 1145243010: Report Pointer Lock webkitMovementX/Y attributes as deprecated. (Closed)

Created:
4 years, 11 months ago by scheib
Modified:
4 years, 11 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Base URL:
https://chromium.googlesource.com/chromium/blink.git@gclient
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Report Pointer Lock webkitMovementX/Y attributes as deprecated. Generate console messages informing developers to use movementX/Y instead of webkitMovementX/Y. Currently PrefixedMouseEventMovementX [1] reports 0.6392% usage, while MouseEventMovementX [2] reports 0.6434% usage. [1] https://www.chromestatus.com/metrics/feature/timeline/popularity/382 [2] https://www.chromestatus.com/metrics/feature/timeline/popularity/434 BUG=398457 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196527

Patch Set 1 : #

Patch Set 2 : Merge TOT #

Patch Set 3 : merge TOT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M Source/core/events/MouseEvent.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
scheib
4 years, 11 months ago (2015-06-03 21:53:32 UTC) #3
Nate Chapin
lgtm
4 years, 11 months ago (2015-06-03 21:55:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145243010/20001
4 years, 11 months ago (2015-06-03 22:00:30 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/46426)
4 years, 11 months ago (2015-06-03 22:06:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145243010/40001
4 years, 11 months ago (2015-06-03 22:46:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/57570)
4 years, 11 months ago (2015-06-03 23:11:32 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145243010/40001
4 years, 11 months ago (2015-06-04 18:32:34 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/57735)
4 years, 11 months ago (2015-06-04 18:35:50 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145243010/60001
4 years, 11 months ago (2015-06-04 19:19:30 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2015-06-04 20:35:45 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196527

Powered by Google App Engine
This is Rietveld 408576698