Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1836)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/BUILD.gn

Issue 1145243006: Port chromevox build to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@externs
Patch Set: Unshare some vars, add TODO for the rest. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/secondary/tools/grit/grit_rule.gni ('k') | chrome/browser/resources/chromeos/braille_ime/BUILD.gn » ('j') | chrome/browser/resources/chromeos/braille_ime/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index ba6b789a4550f948f40cd24e161c15600e17651b..6bd8d80693954dda79bb436ec442291b33eae8b2 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -425,14 +425,8 @@ group("extra_resources") {
]
}
- if (enable_chromevox_next) {
- deps += [
- #'browser/resources/chromeos/chromevox2/chromevox.gyp:chromevox2', TODO(GYP)
- ]
- } else {
- deps += [
- #'browser/resources/chromeos/chromevox/chromevox.gyp:chromevox', TODO(GYP)
- ]
+ if (is_chromeos) {
+ deps += [ "//chrome/browser/resources/chromeos/chromevox" ]
}
if (enable_extensions) {
« no previous file with comments | « build/secondary/tools/grit/grit_rule.gni ('k') | chrome/browser/resources/chromeos/braille_ime/BUILD.gn » ('j') | chrome/browser/resources/chromeos/braille_ime/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698