chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi - Issue 1145243006: Port chromevox build to GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi

Issue 1145243006: Port chromevox build to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@externs

Patch Set: Workaround hardlink related spuroius rebuild issue by using a stamp file (not ideal). Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox_vars.gypi ('k') | chrome/browser/resources/chromeos/chromevox/strings/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi

diff --git a/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi b/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi

index ab5cd4e04ba2b12f2a5ec8e47bc4af4484d8f2c1..758a73e77efd9b6e0db8a86e145b72ac400cfe45 100644

--- a/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi

+++ b/chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi

@@ -8,6 +8,7 @@

# template_manifest_path: a valid Jinja2 file path.

# output_manifest_path: file path for the resulting manifest.

+# chromevox_extension_key: The extension key to include in the manifest.

# The following variables are optional:

@@ -21,7 +22,6 @@

'generate_manifest_script_path': 'tools/generate_manifest.py',

'is_guest_manifest%': 0,

'is_chromevox_classic%': 0,

- 'key': 'MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDltVl1k15pjRzuZfMc3B69inxwm2bZeZ2O8/zFO+NluHnBm3GJ3fzdOoFGJd+M16I8p7zxxQyHeDMfWYASyCeB8XnUEDKjqNLQfCnncsANzHsYoEbYj2nEUML2P13b9q+AAvpCBpAJ4cZp81e9n1y/vbSXHE4385cgkKueItzikQIDAQAB',

'includes': [

'../../../../../build/util/version.gypi',

@@ -41,7 +41,7 @@

'python',

'<(generate_manifest_script_path)',

'--is_guest_manifest=<(is_guest_manifest)',

- '--key=<(key)',

+ '--key=<(chromevox_extension_key)',

'--is_chromevox_classic=<(is_chromevox_classic)',

'--is_js_compressed=<(chromevox_compress_js)',

'--set_version=<(version_full)',