chrome/BUILD.gn - Issue 1145243006: Port chromevox build to GN.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/BUILD.gn

Issue 1145243006: Port chromevox build to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@externs

Patch Set: Workaround hardlink related spuroius rebuild issue by using a stamp file (not ideal). Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/BUILD.gn

diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn

index 74039425cb43958c741c926c3aea86b4a5ccec27..b2282d3547bb2b0d752eb76c41f56d2d4518c6bf 100644

--- a/chrome/BUILD.gn

+++ b/chrome/BUILD.gn

@@ -425,14 +425,8 @@ group("extra_resources") {

]

}

- if (enable_chromevox_next) {

- deps += [

- #'browser/resources/chromeos/chromevox2/chromevox.gyp:chromevox2', TODO(GYP)

- ]

- } else {

- deps += [

- #'browser/resources/chromeos/chromevox/chromevox.gyp:chromevox', TODO(GYP)

- ]

+ if (is_chromeos) {

+ deps += [ "//chrome/browser/resources/chromeos/chromevox" ]

}

if (enable_extensions) {

@@ -715,7 +709,8 @@ template("chrome_repack_material_percent") {

percent = invoker.percent

repack_name = "${target_name}_repack"

- repack_output_file = "$root_gen_dir/repack/chrome_material_${percent}_percent.pak"

+ repack_output_file =

+ "$root_gen_dir/repack/chrome_material_${percent}_percent.pak"

copy_name = target_name