Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 1145233006: Sync the Screen interface with CSSOM View (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Jens Widell
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Sync the Screen interface with CSSOM View http://dev.w3.org/csswg/cssom-view/#the-screen-interface It seems unlikely that availLeft and availTop could be removed, but measure them to know for sure. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195868

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M Source/core/frame/Screen.idl View 1 chunk +9 lines, -5 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
philipj_slow
PTAL
5 years, 6 months ago (2015-05-25 14:39:42 UTC) #2
Jens Widell
LGTM
5 years, 6 months ago (2015-05-25 14:43:13 UTC) #3
Jens Widell
LGTM
5 years, 6 months ago (2015-05-25 14:43:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145233006/1
5 years, 6 months ago (2015-05-25 14:51:46 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-25 16:03:51 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195868

Powered by Google App Engine
This is Rietveld 408576698