Source/core/dom/Attr.idl - Issue 1145233003: Make Attr.localName/name and Element.localName/tagName not nullable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Attr.idl

Issue 1145233003: Make Attr.localName/name and Element.localName/tagName not nullable (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/dom/Attr.idl

diff --git a/Source/core/dom/Attr.idl b/Source/core/dom/Attr.idl

index c5075bae7138a09e2487cacdf6fb6f787718f294..7aafbbca683b8b211eb5501bcebfcd2a0824aedc 100644

--- a/Source/core/dom/Attr.idl

+++ b/Source/core/dom/Attr.idl

@@ -24,9 +24,9 @@

interface Attr : Node {

readonly attribute DOMString? namespaceURI;

readonly attribute DOMString? prefix;

- // FIXME: localName/name/value/nodeValue/textContent should not be nullable.

- readonly attribute DOMString? localName;

- readonly attribute DOMString? name;

+ readonly attribute DOMString localName;

+ readonly attribute DOMString name;

+ // FIXME: value/nodeValue/textContent should not be nullable.

[ImplementedAs=valueForBindings, CustomElementCallbacks] attribute DOMString? value;

[ImplementedAs=valueForBindings, MeasureAs=AttrNodeValue] attribute DOMString? nodeValue; // legacy alias of .value

[ImplementedAs=valueForBindings, MeasureAs=AttrTextContent] attribute DOMString? textContent; // legacy alias of .value

« no previous file with comments | « no previous file | Source/core/dom/Element.idl » ('j') | no next file with comments »