Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1145233003: Make Attr.localName/name and Element.localName/tagName not nullable (Closed)

Created:
5 years, 7 months ago by philipj_slow
Modified:
5 years, 7 months ago
Reviewers:
vivekg, Jens Widell
CC:
vivekg, arv+blink, blink-reviews, blink-reviews-dom_chromium.org, Inactive, dglazkov+blink, eae+blinkwatch, rwlbuis, sof, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make Attr.localName/name and Element.localName/tagName not nullable This changes the generated code from v8SetReturnValueStringOrNull(...) to v8SetReturnValueString(...), but there is no way to create an element or attribute with an empty/null name, so the difference should never be observable. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195726

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -6 lines) Patch
M Source/core/dom/Attr.idl View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
philipj_slow
PTAL
5 years, 7 months ago (2015-05-21 17:48:45 UTC) #2
vivekg
LGTM
5 years, 7 months ago (2015-05-21 18:24:33 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145233003/1
5 years, 7 months ago (2015-05-21 19:38:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=195726
5 years, 7 months ago (2015-05-21 21:04:26 UTC) #7
Jens Widell
5 years, 7 months ago (2015-05-22 08:18:32 UTC) #8
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698