Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(773)

Issue 1145213005: [strong] cache strong object literal maps (Closed)

Created:
5 years, 7 months ago by rossberg
Modified:
5 years, 7 months ago
CC:
v8-dev, Paweł Hajdan Jr., arv (Not doing code reviews), conradw
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] cache strong object literal maps Also, add more literal tests. R=dslomov@chromium.org BUG=v8:3956 LOG=N Committed: https://crrev.com/65bea197ee8a4f04746e0a57f574499817c9b0da Cr-Commit-Position: refs/heads/master@{#28579}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment #

Patch Set 3 : Fix map comparison #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -42 lines) Patch
M include/v8.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M src/contexts.h View 4 chunks +4 lines, -0 lines 0 comments Download
M src/factory.cc View 2 chunks +27 lines, -13 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/runtime/runtime-literals.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M test/mjsunit/strong/literals.js View 1 2 chunks +231 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
rossberg
5 years, 7 months ago (2015-05-21 12:31:18 UTC) #1
arv (Not doing code reviews)
LGTM https://codereview.chromium.org/1145213005/diff/1/test/mjsunit/strong/literals.js File test/mjsunit/strong/literals.js (right): https://codereview.chromium.org/1145213005/diff/1/test/mjsunit/strong/literals.js#newcode105 test/mjsunit/strong/literals.js:105: // TODO(rossberg): teach strongness to FastCloneShallowArrayStub Also, spread ...
5 years, 7 months ago (2015-05-21 13:09:55 UTC) #3
rossberg
https://codereview.chromium.org/1145213005/diff/1/test/mjsunit/strong/literals.js File test/mjsunit/strong/literals.js (right): https://codereview.chromium.org/1145213005/diff/1/test/mjsunit/strong/literals.js#newcode105 test/mjsunit/strong/literals.js:105: // TODO(rossberg): teach strongness to FastCloneShallowArrayStub On 2015/05/21 13:09:55, ...
5 years, 7 months ago (2015-05-21 17:05:09 UTC) #4
Dmitry Lomov (no reviews)
lgtm
5 years, 7 months ago (2015-05-21 17:12:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145213005/20001
5 years, 7 months ago (2015-05-21 17:18:53 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_dbg on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg/builds/5040)
5 years, 7 months ago (2015-05-21 18:19:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145213005/40001
5 years, 7 months ago (2015-05-22 10:16:15 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-22 10:51:56 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 10:52:12 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/65bea197ee8a4f04746e0a57f574499817c9b0da
Cr-Commit-Position: refs/heads/master@{#28579}

Powered by Google App Engine
This is Rietveld 408576698