Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: include/v8config.h

Issue 1145213004: Set V8_HAS_DECLSPEC_SELECTANY for clang-cl (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Use a separate #if for the _MSC_VER check Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8config.h
diff --git a/include/v8config.h b/include/v8config.h
index 991a43afd445c066eda7d5fc6e5d56209a5a0cf4..8e0cbd5ff588dd3915346c1603b6867626fee155 100644
--- a/include/v8config.h
+++ b/include/v8config.h
@@ -199,8 +199,6 @@
#if defined(__GNUC__) // Clang in gcc mode.
# define V8_CC_GNU 1
-#elif defined(_MSC_VER) // Clang in cl mode.
-# define V8_CC_MSVC 1
#endif
// Clang defines __alignof__ as alias for __alignof
@@ -268,11 +266,10 @@
# define V8_HAS_CXX11_ALIGNOF (V8_GNUC_PREREQ(4, 8, 0))
# define V8_HAS_CXX11_STATIC_ASSERT (V8_GNUC_PREREQ(4, 3, 0))
# endif
+#endif
-#elif defined(_MSC_VER)
-
+#if defined(_MSC_VER)
# define V8_CC_MSVC 1
-
# define V8_HAS___ALIGNOF 1
# define V8_HAS_DECLSPEC_ALIGN 1
@@ -281,10 +278,10 @@
# define V8_HAS_DECLSPEC_SELECTANY 1
# define V8_HAS___FORCEINLINE 1
-
#endif
Benedikt Meurer 2015/05/21 04:43:49 Nit: keep the empty line before the #endif.
hans 2015/05/21 15:25:45 Done.
+
// -----------------------------------------------------------------------------
// Helper macros
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698