Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1145203006: [Android] Remove mode concept in detail activity in enhanced bookmarks. (Closed)

Created:
5 years, 7 months ago by Kibeom Kim (inactive)
Modified:
5 years, 7 months ago
Reviewers:
Ian Wen, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove mode concept in detail activity in enhanced bookmarks. BUG=487016 Committed: https://crrev.com/888f1c301d276b43c91b7fd4662336ffe9f0709f Cr-Commit-Position: refs/heads/master@{#331165}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -74 lines) Patch
M chrome/android/java_staging/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkDetailActivity.java View 6 chunks +50 lines, -74 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
Kibeom Kim (inactive)
identical to https://chrome-internal-review.googlesource.com/#/c/216528/
5 years, 7 months ago (2015-05-22 17:16:02 UTC) #2
Ian Wen
lgtm
5 years, 7 months ago (2015-05-22 17:22:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145203006/20001
5 years, 7 months ago (2015-05-22 17:23:08 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-22 17:23:11 UTC) #7
Kibeom Kim (inactive)
newt@ ptal
5 years, 7 months ago (2015-05-22 17:25:15 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145203006/20001
5 years, 7 months ago (2015-05-22 17:38:27 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-22 19:14:02 UTC) #13
newt (away)
lgtm
5 years, 7 months ago (2015-05-22 19:41:24 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145203006/20001
5 years, 7 months ago (2015-05-22 20:18:02 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-22 20:23:56 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 20:24:46 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/888f1c301d276b43c91b7fd4662336ffe9f0709f
Cr-Commit-Position: refs/heads/master@{#331165}

Powered by Google App Engine
This is Rietveld 408576698