Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Side by Side Diff: src/objects-inl.h

Issue 1145183004: Debugger: use weak cells to implement ScriptCache. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 873 matching lines...) Expand 10 before | Expand all | Expand 10 after
884 HeapObject::cast(this)->map() == 884 HeapObject::cast(this)->map() ==
885 HeapObject::cast(this)->GetHeap()->hash_table_map(); 885 HeapObject::cast(this)->GetHeap()->hash_table_map();
886 } 886 }
887 887
888 888
889 bool Object::IsWeakHashTable() const { 889 bool Object::IsWeakHashTable() const {
890 return IsHashTable(); 890 return IsHashTable();
891 } 891 }
892 892
893 893
894 bool Object::IsWeakValueHashTable() const { return IsHashTable(); }
895
896
894 bool Object::IsDictionary() const { 897 bool Object::IsDictionary() const {
895 return IsHashTable() && 898 return IsHashTable() &&
896 this != HeapObject::cast(this)->GetHeap()->string_table(); 899 this != HeapObject::cast(this)->GetHeap()->string_table();
897 } 900 }
898 901
899 902
900 bool Object::IsNameDictionary() const { 903 bool Object::IsNameDictionary() const {
901 return IsDictionary(); 904 return IsDictionary();
902 } 905 }
903 906
(...skipping 2525 matching lines...) Expand 10 before | Expand all | Expand 10 after
3429 CAST_ACCESSOR(SlicedString) 3432 CAST_ACCESSOR(SlicedString)
3430 CAST_ACCESSOR(Smi) 3433 CAST_ACCESSOR(Smi)
3431 CAST_ACCESSOR(String) 3434 CAST_ACCESSOR(String)
3432 CAST_ACCESSOR(StringTable) 3435 CAST_ACCESSOR(StringTable)
3433 CAST_ACCESSOR(Struct) 3436 CAST_ACCESSOR(Struct)
3434 CAST_ACCESSOR(Symbol) 3437 CAST_ACCESSOR(Symbol)
3435 CAST_ACCESSOR(UnseededNumberDictionary) 3438 CAST_ACCESSOR(UnseededNumberDictionary)
3436 CAST_ACCESSOR(WeakCell) 3439 CAST_ACCESSOR(WeakCell)
3437 CAST_ACCESSOR(WeakFixedArray) 3440 CAST_ACCESSOR(WeakFixedArray)
3438 CAST_ACCESSOR(WeakHashTable) 3441 CAST_ACCESSOR(WeakHashTable)
3442 CAST_ACCESSOR(WeakValueHashTable)
3439 3443
3440 3444
3441 // static 3445 // static
3442 template <class Traits> 3446 template <class Traits>
3443 STATIC_CONST_MEMBER_DEFINITION const InstanceType 3447 STATIC_CONST_MEMBER_DEFINITION const InstanceType
3444 FixedTypedArray<Traits>::kInstanceType; 3448 FixedTypedArray<Traits>::kInstanceType;
3445 3449
3446 3450
3447 template <class Traits> 3451 template <class Traits>
3448 FixedTypedArray<Traits>* FixedTypedArray<Traits>::cast(Object* object) { 3452 FixedTypedArray<Traits>* FixedTypedArray<Traits>::cast(Object* object) {
(...skipping 4183 matching lines...) Expand 10 before | Expand all | Expand 10 after
7632 #undef READ_SHORT_FIELD 7636 #undef READ_SHORT_FIELD
7633 #undef WRITE_SHORT_FIELD 7637 #undef WRITE_SHORT_FIELD
7634 #undef READ_BYTE_FIELD 7638 #undef READ_BYTE_FIELD
7635 #undef WRITE_BYTE_FIELD 7639 #undef WRITE_BYTE_FIELD
7636 #undef NOBARRIER_READ_BYTE_FIELD 7640 #undef NOBARRIER_READ_BYTE_FIELD
7637 #undef NOBARRIER_WRITE_BYTE_FIELD 7641 #undef NOBARRIER_WRITE_BYTE_FIELD
7638 7642
7639 } } // namespace v8::internal 7643 } } // namespace v8::internal
7640 7644
7641 #endif // V8_OBJECTS_INL_H_ 7645 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698