Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1145183004: Debugger: use weak cells to implement ScriptCache. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
Reviewers:
ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: use weak cells to implement ScriptCache. R=ulan@chromium.org Committed: https://crrev.com/720d9c280a8e7415ed77ac846e955a8e163d834f Cr-Commit-Position: refs/heads/master@{#28539}

Patch Set 1 #

Patch Set 2 : destroy and recreate global handle #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -89 lines) Patch
M src/debug.h View 1 chunk +6 lines, -15 lines 0 comments Download
M src/debug.cc View 1 2 chunks +32 lines, -72 lines 0 comments Download
M src/objects.h View 1 2 5 chunks +25 lines, -2 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +43 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Yang
5 years, 7 months ago (2015-05-20 14:32:31 UTC) #1
Yang
On 2015/05/20 14:32:31, Yang wrote: updated.
5 years, 7 months ago (2015-05-21 08:14:41 UTC) #2
ulan
lgtm
5 years, 7 months ago (2015-05-21 08:21:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145183004/20001
5 years, 7 months ago (2015-05-21 08:55:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel/builds/1051)
5 years, 7 months ago (2015-05-21 09:02:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145183004/40001
5 years, 7 months ago (2015-05-21 09:27:39 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-21 10:35:56 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 10:36:14 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/720d9c280a8e7415ed77ac846e955a8e163d834f
Cr-Commit-Position: refs/heads/master@{#28539}

Powered by Google App Engine
This is Rietveld 408576698