Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 1145173002: Add benchmark that tests garbage collector and idle time handler. (Closed)

Created:
5 years, 7 months ago by ulan
Modified:
5 years, 7 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add benchmark that tests garbage collector and idle time handler. High memory usage is forced by duplicate tabs in the same process. BUG= CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/22ead27351ef035b4b9f983bdc4a4077a1455d77 Cr-Commit-Position: refs/heads/master@{#330930}

Patch Set 1 #

Patch Set 2 : Add comments #

Patch Set 3 : #

Total comments: 12

Patch Set 4 : Address Sami's comments #

Patch Set 5 : Whitespace #

Patch Set 6 : Disable for Android to avoid OOM crash (benchmark needs > 700MB) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -0 lines) Patch
M tools/perf/benchmarks/memory.py View 1 2 3 4 5 1 chunk +18 lines, -0 lines 0 comments Download
A tools/perf/page_sets/idle_multi_tab_cases.js View 1 1 chunk +19 lines, -0 lines 0 comments Download
A tools/perf/page_sets/idle_multi_tab_cases.py View 1 2 3 4 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
ulan
Hi Sami, would you be the right reviewer for this?
5 years, 7 months ago (2015-05-20 14:32:44 UTC) #2
Sami
Thanks for the patch. Overall the logic looks good, I just had some style nits. ...
5 years, 7 months ago (2015-05-20 15:52:20 UTC) #3
ulan
Thank you for review! > I wonder about the runtime of this -- it looks ...
5 years, 7 months ago (2015-05-20 16:14:43 UTC) #4
Sami
Thanks, lgtm. cc +sullivan in case she has opinions about the increased test run time.
5 years, 7 months ago (2015-05-20 16:22:54 UTC) #5
sullivan
On 2015/05/20 16:22:54, Sami wrote: > Thanks, lgtm. > > cc +sullivan in case she ...
5 years, 7 months ago (2015-05-20 19:22:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145173002/70001
5 years, 7 months ago (2015-05-21 07:58:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145173002/90001
5 years, 7 months ago (2015-05-21 09:24:45 UTC) #11
commit-bot: I haz the power
Committed patchset #6 (id:90001)
5 years, 7 months ago (2015-05-21 11:17:15 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 11:18:03 UTC) #13
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/22ead27351ef035b4b9f983bdc4a4077a1455d77
Cr-Commit-Position: refs/heads/master@{#330930}

Powered by Google App Engine
This is Rietveld 408576698