Include a deprecation warning when people only use "gcm_user_visible_only".

Include a deprecation warning when people only use "gcm_user_visible_only".

Usage of the "gcm_user_visible_only" Manifest key has been deprecated in favor
of using PushSubscriptionOptions when subscribing. Show a deprecation
warning when only the former is used.

BUG=471534
Committed: https://crrev.com/2d90256078aca21c9ada9ec7699662596796d65c
Cr-Commit-Position: refs/heads/master@{#330735}

[johnme, 2015-05-20 14:05:41]

johnme@chromium.org changed reviewers:
+ johnme@chromium.org

[johnme, 2015-05-20 14:05:42]

lgtm with nits

https://codereview.chromium.org/1145163002/diff/1/content/renderer/push_messa...
File content/renderer/push_messaging/push_messaging_dispatcher.cc (right):

https://codereview.chromium.org/1145163002/diff/1/content/renderer/push_messa...
content/renderer/push_messaging/push_messaging_dispatcher.cc:26: const char
kManifestDeprecationWarning[] =
Move to anonymous namespace?

https://codereview.chromium.org/1145163002/diff/1/content/renderer/push_messa...
content/renderer/push_messaging/push_messaging_dispatcher.cc:28: "removed in
Chrome 45, around August 2015. Use PushSubscriptionOptions "
Nit: How about "Call pushManager.subscribe({userVisibleOnly:true}) instead (see
https://w3c.github.io/push-api/#pushsubscriptionoptions-dictionary)." instead of
the last sentence.

https://codereview.chromium.org/1145163002/diff/1/content/renderer/push_messa...
content/renderer/push_messaging/push_messaging_dispatcher.cc:92:
render_frame()->GetWebFrame()->addMessageToConsole(message);
Ideally we'd log no more than once per page load; but I guess pages are unlikely
to subscribe many times per page load, so it's probably fine.

[Peter Beverloo, 2015-05-20 14:15:14]

https://codereview.chromium.org/1145163002/diff/1/content/renderer/push_messa...
File content/renderer/push_messaging/push_messaging_dispatcher.cc (right):

https://codereview.chromium.org/1145163002/diff/1/content/renderer/push_messa...
content/renderer/push_messaging/push_messaging_dispatcher.cc:26: const char
kManifestDeprecationWarning[] =
On 2015/05/20 14:05:41, johnme wrote:
> Move to anonymous namespace?

No, constants are internally linked by default so it wouldn't make a difference.

https://codereview.chromium.org/1145163002/diff/1/content/renderer/push_messa...
content/renderer/push_messaging/push_messaging_dispatcher.cc:28: "removed in
Chrome 45, around August 2015. Use PushSubscriptionOptions "
On 2015/05/20 14:05:41, johnme wrote:
> Nit: How about "Call pushManager.subscribe({userVisibleOnly:true}) instead
(see
> https://w3c.github.io/push-api/#pushsubscriptionoptions-dictionary).%22
instead of
> the last sentence.

Changed..

https://codereview.chromium.org/1145163002/diff/1/content/renderer/push_messa...
content/renderer/push_messaging/push_messaging_dispatcher.cc:92:
render_frame()->GetWebFrame()->addMessageToConsole(message);
On 2015/05/20 14:05:41, johnme wrote:
> Ideally we'd log no more than once per page load; but I guess pages are
unlikely
> to subscribe many times per page load, so it's probably fine.

Acknowledged.

[johnme, 2015-05-20 14:29:59]

The CQ bit was checked by johnme@chromium.org

[johnme, 2015-05-20 14:29:59]

The patchset sent to the CQ was uploaded after l-g-t-m from johnme@chromium.org
Link to the patchset: https://codereview.chromium.org/1145163002/#ps20001
(title: "comments")

[commit-bot: I haz the power, 2015-05-20 14:30:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1145163002/20001

[commit-bot: I haz the power, 2015-05-20 15:12:43]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-20 15:13:41]

Patchset 2 (id:??) landed as
https://crrev.com/2d90256078aca21c9ada9ec7699662596796d65c
Cr-Commit-Position: refs/heads/master@{#330735}