Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1145153005: Revert of [Android] Remove adb_commands from telemetry. (Closed)

Created:
5 years, 6 months ago by alancutter (OOO until 2018)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, perezju, telemetry-reviews_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Remove adb_commands from telemetry. (patchset #13 id:240001 of https://codereview.chromium.org/1141833003/) Reason for revert: On 2015/06/03 at 03:23:53, commit-bot wrote: > Patchset 13 (id:??) landed as https://crrev.com/c951c9e158d55d2be18f8226200679aee55f336d > Cr-Commit-Position: refs/heads/master@{#332538} This change breaks --browser=list when non-rooted Android devices are attached. $ tools/perf/run_benchmark --browser=list ERROR:root:Fail to create platform instance for Android device 04f120591b9223e1. Traceback (most recent call last): <module> at tools/perf/run_benchmark:20 sys.exit(benchmark_runner.main(config)) main at tools/telemetry/telemetry/benchmark_runner.py:433 options, args = parser.parse_args() ParseArgs at tools/telemetry/telemetry/core/browser_options.py:179 device) Cacher at tools/telemetry/telemetry/decorators.py:30 cacher.__cache[key] = obj(*args, **kwargs) GetAllAvailableBrowsers at tools/telemetry/telemetry/core/browser_finder.py:147 browser_finder.FindAllAvailableBrowsers(options, device)) FindAllAvailableBrowsers at tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:217 android_platform = platform.GetPlatformForDevice(device, finder_options) GetPlatformForDevice at tools/telemetry/telemetry/core/platform/__init__.py:58 finder_options)) CreatePlatformForDevice at tools/telemetry/telemetry/core/platform/android_platform_backend.py:186 platform_backend = AndroidPlatformBackend(device, finder_options) __init__ at tools/telemetry/telemetry/core/platform/android_platform_backend.py:148 self._device.EnableRoot() TimeoutRetryWrapper at build/android/pylib/device/decorators.py:57 return timeout_retry.Run(impl, timeout, retries) Run at build/android/pylib/utils/timeout_retry.py:161 thread_group.JoinAll(child_thread.GetWatcher()) JoinAll at build/android/pylib/utils/reraiser_thread.py:143 self._JoinAll(watcher) _JoinAll at build/android/pylib/utils/reraiser_thread.py:130 thread.ReraiseIfException() run at build/android/pylib/utils/reraiser_thread.py:76 self._ret = self._func(*self._args, **self._kwargs) RunOnTimeoutThread at build/android/pylib/utils/timeout_retry.py:150 ret[0] = func(*args, **kwargs) impl at build/android/pylib/device/decorators.py:51 return f(*args, **kwargs) EnableRoot at build/android/pylib/device/device_utils.py:289 'Cannot enable root in user builds.', str(self)) CommandFailedError: (device: 04f120591b9223e1) Cannot enable root in user builds. Locals: retries : 3 timeout : 30 Original issue's description: > [Android] Remove adb_commands from telemetry. > > ...because it's an abomination. > > BUG=476709 > > Committed: https://crrev.com/c951c9e158d55d2be18f8226200679aee55f336d > Cr-Commit-Position: refs/heads/master@{#332538} TBR=dtu@chromium.org,nednguyen@google.com,primiano@chromium.org,skyostil@chromium.org,sullivan@chromium.org,picksi@chromium.org,zhenw@chromium.org,jbudorick@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=476709 Committed: https://crrev.com/79bdcb66e8a1c9aeccda1af0130953ab99c6b81d Cr-Commit-Position: refs/heads/master@{#332560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+596 lines, -483 lines) Patch
M build/android/pylib/device/device_utils.py View 1 chunk +16 lines, -0 lines 0 comments Download
M build/android/pylib/screenshot.py View 2 chunks +1 line, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/android_process.py View 2 chunks +2 lines, -9 lines 0 comments Download
A tools/telemetry/telemetry/core/backends/adb_commands.py View 1 chunk +142 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/android_app_backend.py View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/android_command_line_backend.py View 3 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/android_command_line_backend_unittest.py View 3 chunks +11 lines, -22 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_backend.py View 8 chunks +20 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py View 3 chunks +2 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/backends/chrome/android_browser_finder_unittest.py View 3 chunks +21 lines, -27 lines 0 comments Download
M tools/telemetry/telemetry/core/forwarders/android_forwarder.py View 9 chunks +31 lines, -31 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_action_runner.py View 7 chunks +9 lines, -9 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_device.py View 4 chunks +31 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_device_unittest.py View 1 chunk +84 lines, -91 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend.py View 15 chunks +23 lines, -90 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/android_platform_backend_unittest.py View 6 chunks +25 lines, -67 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_prebuilt_profiler_helper.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_screen_recorder_profiler.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_traceview_profiler.py View 3 chunks +10 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/java_heap_profiler.py View 2 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/netlog_profiler.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/oomkiller_profiler.py View 3 chunks +4 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py View 4 chunks +17 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/tcmalloc_heap_profiler.py View 1 chunk +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/tcpdump_profiler.py View 3 chunks +11 lines, -19 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/v8_profiler.py View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/vtune_profiler.py View 2 chunks +7 lines, -7 lines 0 comments Download
M tools/telemetry/telemetry/unittest_util/system_stub.py View 2 chunks +93 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
alancutter (OOO until 2018)
Created Revert of [Android] Remove adb_commands from telemetry.
5 years, 6 months ago (2015-06-03 05:38:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145153005/1
5 years, 6 months ago (2015-06-03 05:40:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 05:41:48 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 05:42:38 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/79bdcb66e8a1c9aeccda1af0130953ab99c6b81d
Cr-Commit-Position: refs/heads/master@{#332560}

Powered by Google App Engine
This is Rietveld 408576698