Chromium Code Reviews

Issue 1145153002: Have SkPicture inherit from SkRefCnt. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Have SkPicture inherit from SkRefCnt. This re-enables adoption tracking for SkPictures in Blink, which should be green now that crrev.com/1136123011 has landed. BUG=skia:3847 Committed: https://skia.googlesource.com/skia/+/fd6a07b1e835f692b7dcb837027db6d5cc253618

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+1 line, -4 lines)
M include/core/SkPicture.h View 1 chunk +1 line, -4 lines 0 comments

Messages

Total messages: 10 (4 generated)
mtklein_C
5 years, 7 months ago (2015-05-20 13:28:59 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145153002/1
5 years, 7 months ago (2015-05-20 13:29:42 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 13:35:36 UTC) #6
reed1
lgtm
5 years, 7 months ago (2015-05-20 17:54:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145153002/1
5 years, 7 months ago (2015-05-20 17:55:08 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:55:55 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fd6a07b1e835f692b7dcb837027db6d5cc253618

Powered by Google App Engine