Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 11451036: Do not call ResolveCompileInstanceFunction from the lookup stub. (Closed)

Created:
8 years ago by Kevin Millikin (Google)
Modified:
8 years ago
Reviewers:
srdjan
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Do not call ResolveCompileInstanceFunction from the lookup stub. The InstanceFunctionLookup stub is only called after the inline cache miss handler. The miss handler ensures that ResolveCompileInstanceCallTarget is called. BUG= Committed: https://code.google.com/p/dart/source/detail?r=15842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -155 lines) Patch
M runtime/vm/code_generator.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 2 chunks +30 lines, -65 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 2 chunks +31 lines, -66 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Google)
There was a weird permutation of the IC data and arguments descriptor registers on both ...
8 years ago (2012-12-06 15:17:59 UTC) #1
srdjan
8 years ago (2012-12-06 23:02:41 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698