Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1145103006: BindTransformFeedback(0) is legal. (Closed)

Created:
5 years, 7 months ago by Zhenyao Mo
Modified:
5 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BindTransformFeedback(0) is legal. 0 is the default transform feedback. Currently we generate an INVALID_OP in command buffer service, which is incorrect. BUG=429053 TEST=gpu_unittests R=bajones@chromium.org Committed: https://crrev.com/5347489d1d33c82a670350d027a3c00b002c704a Cr-Commit-Position: refs/heads/master@{#331733}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M gpu/command_buffer/service/context_group.h View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Zhenyao Mo
bajones: PTAL
5 years, 7 months ago (2015-05-27 23:40:55 UTC) #1
Ken Russell (switch to Gerrit)
The code change looks good according to the spec, but is there a test for ...
5 years, 7 months ago (2015-05-27 23:48:14 UTC) #3
bajones
On 2015/05/27 23:40:55, Zhenyao Mo wrote: > bajones: PTAL LGTM! Thanks!
5 years, 7 months ago (2015-05-27 23:49:02 UTC) #4
Zhenyao Mo
5 years, 7 months ago (2015-05-27 23:51:18 UTC) #5
Zhenyao Mo
On 2015/05/27 23:48:14, Ken Russell wrote: > The code change looks good according to the ...
5 years, 7 months ago (2015-05-27 23:51:53 UTC) #6
bajones
On 2015/05/27 23:51:53, Zhenyao Mo wrote: > On 2015/05/27 23:48:14, Ken Russell wrote: > > ...
5 years, 7 months ago (2015-05-27 23:52:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1145103006/20001
5 years, 7 months ago (2015-05-28 02:07:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-28 02:59:08 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-28 03:00:13 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5347489d1d33c82a670350d027a3c00b002c704a
Cr-Commit-Position: refs/heads/master@{#331733}

Powered by Google App Engine
This is Rietveld 408576698