Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: sky/engine/core/painting/Rect.cpp

Issue 1145103005: Add DartHandleCache and use it to cache strings used when converting Rect and (Closed) Base URL: git@github.com:/domokit/mojo.git@master
Patch Set: simplify Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/painting/Point.cpp ('k') | sky/engine/core/script/dom_dart_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/painting/Rect.cpp
diff --git a/sky/engine/core/painting/Rect.cpp b/sky/engine/core/painting/Rect.cpp
index 4a0c643cc8bd09ed69f8c0e8da2e3fda36bd3ad7..625d45614e508d9bbbf12cf9f18087cc497fa126 100644
--- a/sky/engine/core/painting/Rect.cpp
+++ b/sky/engine/core/painting/Rect.cpp
@@ -5,8 +5,9 @@
#include "sky/engine/config.h"
#include "sky/engine/core/painting/Rect.h"
+#include "sky/engine/core/script/dom_dart_state.h"
#include "sky/engine/tonic/dart_error.h"
-#include "sky/engine/tonic/dart_state.h"
+#include "sky/engine/tonic/dart_value.h"
#include "base/logging.h"
namespace blink {
@@ -23,7 +24,7 @@ Rect DartConverter<Rect, void>::FromArgumentsWithNullCheck(
DCHECK(!LogIfError(dart_rect));
Dart_Handle value = Dart_GetField(dart_rect,
- Dart_NewStringFromCString("_value"));
+ DOMDartState::Current()->value_handle());
if (Dart_IsNull(value))
return result;
« no previous file with comments | « sky/engine/core/painting/Point.cpp ('k') | sky/engine/core/script/dom_dart_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698