Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Issue 1145103005: Add DartHandleCache and use it to cache strings used when converting Rect and (Closed)

Created:
5 years, 7 months ago by Matt Perry
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add DartHandleCache and use it to cache strings used when converting Rect and Point classes. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ff336f0c8d420dba0f78165bf77429009ec7cb3e

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M sky/engine/core/core.gni View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M sky/engine/core/painting/Point.cpp View 1 2 2 chunks +7 lines, -5 lines 0 comments Download
M sky/engine/core/painting/Rect.cpp View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M sky/engine/core/script/dom_dart_state.h View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M sky/engine/core/script/dom_dart_state.cc View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M sky/engine/tonic/dart_state.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Matt Perry
5 years, 7 months ago (2015-05-27 19:46:52 UTC) #2
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-27 19:54:55 UTC) #3
Matt Perry
Wait.. do we plan on only ever having one DartState/Dart isolate? I just realized this ...
5 years, 7 months ago (2015-05-27 20:18:15 UTC) #4
abarth-chromium
On 2015/05/27 at 20:18:15, mpcomplete wrote: > Wait.. do we plan on only ever having ...
5 years, 7 months ago (2015-05-27 20:20:06 UTC) #5
Matt Perry
Done. I had to add a callback for when the isolate is created, so we ...
5 years, 7 months ago (2015-05-27 20:57:12 UTC) #6
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-27 23:33:50 UTC) #7
Matt Perry
5 years, 6 months ago (2015-05-28 17:39:37 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
ff336f0c8d420dba0f78165bf77429009ec7cb3e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698