Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(378)

Unified Diff: src/heap/gc-idle-time-handler.h

Issue 1145103002: Take freed handles into account when scheduling idle GCs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/gc-idle-time-handler.cc » ('j') | src/heap/heap.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/gc-idle-time-handler.h
diff --git a/src/heap/gc-idle-time-handler.h b/src/heap/gc-idle-time-handler.h
index efa4869956e3f7c5f7f22a6ad2c05f65de443779..5c0a80a1d25653107afac42b393bc16179977646 100644
--- a/src/heap/gc-idle-time-handler.h
+++ b/src/heap/gc-idle-time-handler.h
@@ -197,13 +197,17 @@ class GCIdleTimeHandler {
long_idle_notifications_(0),
background_idle_notifications_(0),
idle_times_which_made_no_progress_per_mode_(0),
+ next_gc_likely_to_collect_more_(false),
mode_(kReduceLatency) {}
GCIdleTimeAction Compute(double idle_time_in_ms, HeapState heap_state);
void NotifyIdleMarkCompact() { ++idle_mark_compacts_; }
- void NotifyMarkCompact() { ++mark_compacts_; }
+ void NotifyMarkCompact(bool next_gc_likely_to_collect_more) {
+ next_gc_likely_to_collect_more_ = next_gc_likely_to_collect_more;
+ ++mark_compacts_;
+ }
void NotifyScavenge() { ++scavenges_; }
@@ -261,6 +265,8 @@ class GCIdleTimeHandler {
// Idle notifications with no progress in the current mode.
int idle_times_which_made_no_progress_per_mode_;
+ bool next_gc_likely_to_collect_more_;
+
Mode mode_;
DISALLOW_COPY_AND_ASSIGN(GCIdleTimeHandler);
« no previous file with comments | « no previous file | src/heap/gc-idle-time-handler.cc » ('j') | src/heap/heap.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698