src/heap/gc-idle-time-handler.cc - Issue 1145103002: Take freed handles into account when scheduling idle GCs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/gc-idle-time-handler.cc

Issue 1145103002: Take freed handles into account when scheduling idle GCs. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap/gc-idle-time-handler.cc

diff --git a/src/heap/gc-idle-time-handler.cc b/src/heap/gc-idle-time-handler.cc

index 0a174d533db9be28da9c3f31c249cc2a35a24848..e88710bd1d10533c8905aab3ef1a8422e95feba2 100644

--- a/src/heap/gc-idle-time-handler.cc

+++ b/src/heap/gc-idle-time-handler.cc

@@ -399,7 +399,8 @@ GCIdleTimeHandler::Mode GCIdleTimeHandler::NextMode(

}

break;

case kReduceMemory:

- if (idle_mark_compacts_ >= kMaxIdleMarkCompacts) {

+ if (idle_mark_compacts_ >= kMaxIdleMarkCompacts ||

+ (idle_mark_compacts_ > 0 && !next_gc_likely_to_collect_more_)) {

return kDone;

}

if (mutator_gcs > idle_mark_compacts_) {