Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 11451021: Only launch a second un-sandboxed gpu process on Windows. (Closed)

Created:
8 years ago by Zhenyao Mo
Modified:
8 years ago
Reviewers:
apatrick_chromium
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Only launch a second un-sandboxed gpu process on Windows. On Linux and Mac, we can do gpu info collection with sandbox on, so no need for a second un-sandboxed gpu process. BUG=162928 TEST=about:gpu correctly reports sandboxed=true on chromeos Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171379

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -22 lines) Patch
M content/browser/gpu/gpu_data_manager_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 chunk +27 lines, -22 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Zhenyao Mo
Al: please review.
8 years ago (2012-12-05 23:26:10 UTC) #1
apatrick_chromium
https://codereview.chromium.org/11451021/diff/1/content/gpu/gpu_child_thread.cc File content/gpu/gpu_child_thread.cc (right): https://codereview.chromium.org/11451021/diff/1/content/gpu/gpu_child_thread.cc#newcode177 content/gpu/gpu_child_thread.cc:177: gpu_info_.sandboxed = sandboxed; Do any of the implementations of ...
8 years ago (2012-12-05 23:31:08 UTC) #2
Zhenyao Mo
https://codereview.chromium.org/11451021/diff/1/content/gpu/gpu_child_thread.cc File content/gpu/gpu_child_thread.cc (right): https://codereview.chromium.org/11451021/diff/1/content/gpu/gpu_child_thread.cc#newcode177 content/gpu/gpu_child_thread.cc:177: gpu_info_.sandboxed = sandboxed; On 2012/12/05 23:31:08, apatrick_chromium wrote: > ...
8 years ago (2012-12-05 23:34:11 UTC) #3
apatrick_chromium
8 years ago (2012-12-05 23:35:35 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698